Project API #354
Merged
Project API #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 24, 2020 13:54
…ojects � Conflicts: � github4s/src/main/scala/github4s/Decoders.scala � github4s/src/main/scala/github4s/Github.scala � github4s/src/main/scala/github4s/modules/GithubAPIs.scala � github4s/src/test/scala/github4s/utils/BaseIntegrationSpec.scala � github4s/src/test/scala/github4s/utils/BaseSpec.scala � github4s/src/test/scala/github4s/utils/TestData.scala
anamariamv
requested review from
rafaparadela,
BenFradet,
juanpedromoreno and
bond15
BenFradet
approved these changes
Feb 26, 2020
| * @return GHResponse with the list of columns belonging to this project id | ||
| */ | ||
| def listColumns( | ||
| project_id: Int, |
There was a problem hiding this comment.
Suggested change
| project_id: Int, | |
| projectId: Int, |
wdyt?
github4s/src/main/scala/github4s/interpreters/ProjectsInterpreter.scala
Outdated
Show resolved
Hide resolved
Co-Authored-By: Ben Fradet <benjamin.fradet@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 92.11% 92.27% +0.16%
==========================================
Files 23 24 +1
Lines 507 518 +11
Branches 1 1
==========================================
+ Hits 467 478 +11
Misses 40 40
Continue to review full report at Codecov.
|
Co-Authored-By: Ben Fradet <benjamin.fradet@gmail.com>
Co-Authored-By: Ben Fradet <benjamin.fradet@gmail.com>
…ter.scala Co-Authored-By: Ben Fradet <benjamin.fradet@gmail.com>
Co-Authored-By: Ben Fradet <benjamin.fradet@gmail.com>
bond15
approved these changes
Feb 26, 2020
github4s/src/test/scala/github4s/integration/GHProjectsSpec.scala
Outdated
Show resolved
Hide resolved
juanpedromoreno
approved these changes
Feb 29, 2020
rafaparadela
reviewed
Mar 2, 2020
added 2 commits
March 2, 2020 14:59
rafaparadela
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves:
#338 and #339