-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List milestone and List Labels in a project #359
Conversation
…bels � Conflicts: � github4s/src/main/scala/github4s/Decoders.scala
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 92.27% 92.39% +0.11%
==========================================
Files 24 24
Lines 518 526 +8
Branches 1 0 -1
==========================================
+ Hits 478 486 +8
Misses 40 40
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , just minor comments
github4s/src/main/scala/github4s/interpreters/IssuesInterpreter.scala
Outdated
Show resolved
Hide resolved
github4s/src/main/scala/github4s/interpreters/IssuesInterpreter.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Ben's comments covered mine.
…r.scala Co-Authored-By: Ben Fradet <benjamin.fradet@gmail.com>
This PR solves #341 and #340