Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework GHResponse to incorporate useful data on unhappy path #367

Merged
merged 4 commits into from
Mar 12, 2020

Conversation

BenFradet
Copy link
Contributor

partially addresses #363 , cc @dcsobral

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #367 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   92.45%   92.64%   +0.18%     
==========================================
  Files          24       23       -1     
  Lines         530      530              
  Branches        0        1       +1     
==========================================
+ Hits          490      491       +1     
+ Misses         40       39       -1     
Impacted Files Coverage Δ
...ub4s/src/main/scala/github4s/GithubResponses.scala 100.00% <ø> (ø)
...ub4s/src/main/scala/github4s/http/HttpClient.scala 93.75% <100.00%> (+0.20%) ⬆️
.../scala/github4s/interpreters/AuthInterpreter.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc805c2...840b0bd. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BenFradet BenFradet merged commit 2728553 into master Mar 12, 2020
@BenFradet BenFradet deleted the error-handling branch March 12, 2020 06:50
@juanpedromoreno juanpedromoreno mentioned this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants