Adds list and search methods for issues #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
approved these changes
Jan 3, 2017
| .execFuture(headerUserAgent) | ||
|
|
||
| testFutureIsRight[SearchIssuesResult](response, { r => | ||
| r.result.total_count > 1 shouldBe true |
There was a problem hiding this comment.
This assert is saying that at least should exist two issues, which is incongruent with the test banner return at least one issue for a valid query
|
|
||
| response should be('right) | ||
| response.toOption map { r ⇒ | ||
| r.result.total_count > 1 shouldBe true |
| * | ||
| * @param accessToken to identify the authenticated user | ||
| * @param headers optional user headers to include in the request | ||
| * @param searchParams list of search params |
There was a problem hiding this comment.
Let's include what query parameter does too, to complete the scaladoc ;)
Current coverage is 86.34% (diff: 75.55%)@@ master #47 diff @@
==========================================
Files 22 27 +5
Lines 350 388 +38
Methods 348 384 +36
Messages 0 0
Branches 2 3 +1
==========================================
+ Hits 308 335 +27
- Misses 42 53 +11
Partials 0 0
|
* Adds tests for JS * Fixes problems with encoding params
fedefernandez
force-pushed
the
search-and-list-issues
branch
from
beda8e5
to
3fc5fed
Compare
|
Ready for a second review! Thanks @juanpedromoreno |
|
LGTM! Thanks @fedefernandez ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the list and search methods for issues
Please @juanpedromoreno could you review? I'm especially interested in your opinion with the definition of
SearchParamThanks!