Get Blob support #494
Merged
Get Blob support #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFradet
reviewed
May 27, 2020
Comment on lines
125
to
153
| val gh = clientResource.map { client => | ||
| Github[IO](client, accessToken) | ||
| } | ||
|
|
||
| val response: GHResponse[NonEmptyList[Content]] = gh | ||
| .use( | ||
| _.repos.getContents(validRepoOwner, validRepoName, validFilePath, headers = headerUserAgent) | ||
| ) | ||
| .unsafeRunSync() | ||
|
|
||
| val fileContentO = for { | ||
| res <- response.result.toOption | ||
| content <- res.head.content | ||
| } yield content | ||
|
|
||
| fileContentO.isDefined shouldBe true | ||
|
|
||
| val blobResponse = for { | ||
| res <- response.result.toOption | ||
| } yield gh.use( | ||
| _.gitData.getBlob(validRepoOwner, validRepoName, res.head.sha, headers = headerUserAgent) | ||
| ) | ||
|
|
||
| blobResponse.isDefined shouldBe true | ||
|
|
||
| val responseBlob = blobResponse.get.unsafeRunSync() | ||
|
|
||
| testIsRight[BlobContent](responseBlob, r => r.content shouldBe fileContentO) | ||
| response.statusCode shouldBe okStatusCode |
There was a problem hiding this comment.
I think this can be simplified a bit: https://gist.github.com/BenFradet/4d5e85580ef986d7c39300d5690af867
There was a problem hiding this comment.
How about this approach?
Co-authored-by: Ben Fradet <benjamin.fradet@gmail.com>
Co-authored-by: Ben Fradet <benjamin.fradet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.