Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare repository for next .github release and SBT build improvements #501

Merged
merged 22 commits into from
Jun 2, 2020

Conversation

alejandrohdezma
Copy link
Contributor

What has been done in this PR?

Prepare project for next .github release

  • Add ci-publish command alias that will be used instead of ci-release for publishing artifacts.
  • Move docs templates to docs folder (as mdoc is expected).
  • Move microsite files to microsite folder.
  • Run github before ci-docs & ci-publish.
  • Remove ci-microsite (it gets inline in ci-docs).
  • Add actions.yml file that will be used by next .github release workflows to read pre/post conditions to run before/after ci-* commands.

Simplify SBT build

  • Re-order settings.
  • Remove unneeded settings.
  • Remove old sbt-org-policies markers.
  • Add sbt-remove-test-from-pom to avoid publishing test dependencies to POM.
  • Add sbt-codecov to run tests with coverage and auto-upload to Codecov.

Update versions

  • Update plugins to latest versions
  • Update Scala versions to 2.13.2/2.12.11

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #501 into master will increase coverage by 11.17%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #501       +/-   ##
===========================================
+ Coverage   79.19%   90.37%   +11.17%     
===========================================
  Files          23       24        +1     
  Lines         548      613       +65     
  Branches        2        3        +1     
===========================================
+ Hits          434      554      +120     
+ Misses        114       59       -55     
Impacted Files Coverage Δ
github4s/src/main/scala/github4s/Github.scala 100.00% <ø> (+100.00%) ⬆️
...hub4s/src/main/scala/github4s/GithubIOSyntax.scala 0.00% <ø> (ø)
...s/src/main/scala/github4s/domain/PullRequest.scala 100.00% <ø> (+100.00%) ⬆️
...4s/src/main/scala/github4s/domain/Repository.scala 100.00% <ø> (ø)
...s/src/main/scala/github4s/domain/SearchParam.scala 16.66% <ø> (ø)
.../src/main/scala/github4s/http/RequestBuilder.scala 100.00% <ø> (+100.00%) ⬆️
.../github4s/interpreters/ActivitiesInterpreter.scala 100.00% <ø> (ø)
...scala/github4s/interpreters/GistsInterpreter.scala 100.00% <ø> (ø)
...thub4s/interpreters/OrganizationsInterpreter.scala 100.00% <ø> (ø)
...ithub4s/interpreters/PullRequestsInterpreter.scala 100.00% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb47146...2d14932. Read the comment docs.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

project/ProjectPlugin.scala Show resolved Hide resolved
project/ProjectPlugin.scala Outdated Show resolved Hide resolved
@alejandrohdezma alejandrohdezma merged commit 1ff928e into master Jun 2, 2020
@alejandrohdezma alejandrohdezma deleted the prepare-for-dot-github-release branch June 2, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants