Add check if user is a collaborator

[zachkirlew]

No description provided.

[codecov]

Codecov Report

Merging #530 into master will decrease coverage by 13.46%.
The diff coverage is 21.05%.

@@             Coverage Diff             @@
##           master     #530       +/-   ##
===========================================
- Coverage   90.52%   77.06%   -13.47%     
===========================================
  Files          24       24               
  Lines         623      641       +18     
  Branches        1        1               
===========================================
- Hits          564      494       -70     
- Misses         59      147       +88     

Impacted Files	Coverage Δ
...ub4s/src/main/scala/github4s/http/HttpClient.scala	12.12% <0.00%> (-75.38%)	⬇️
...ithub4s/interpreters/RepositoriesInterpreter.scala	90.80% <44.44%> (-5.35%)	⬇️
github4s/src/main/scala/github4s/Github.scala	0.00% <0.00%> (-100.00%)	⬇️
...ithub4s/src/main/scala/github4s/GithubConfig.scala	0.00% <0.00%> (-100.00%)	⬇️
...4s/src/main/scala/github4s/http/Http4sSyntax.scala	0.00% <0.00%> (-100.00%)	⬇️
...s/src/main/scala/github4s/domain/PullRequest.scala	0.00% <0.00%> (-100.00%)	⬇️
...s/src/main/scala/github4s/modules/GithubAPIs.scala	0.00% <0.00%> (-100.00%)	⬇️
.../src/main/scala/github4s/http/RequestBuilder.scala	0.00% <0.00%> (-100.00%)	⬇️
.../scala/github4s/interpreters/AuthInterpreter.scala	60.00% <0.00%> (-40.00%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6c894...6f49b1c. Read the comment docs.

[BenFradet]

LGTM 👍 , I just have a few minor comments.

[BenFradet]

Trying to run the tests locally I found the following issue: buildResponse relies on http4s' attemptAs which expects a non-empty body so we will always get a left.

[zachkirlew]

Trying to run the tests locally I found the following issue: buildResponse relies on http4s' attemptAs which expects a non-empty body so we will always get a left.

buildResponse isn't called in HttpClient.getWithoutResponse which is the method used in userIsCollaborator?

[BenFradet]

Trying to run the tests locally I found the following issue: buildResponse relies on http4s' attemptAs which expects a non-empty body so we will always get a left.

buildResponse isn't called in HttpClient.getWithoutResponse which is the method used in userIsCollaborator?

getWithoutResponse calls run which calls buildResponse.

To run the tests locally you need a GITHUB_TOKEN env var: https://47degrees.github.io/github4s/contributing#token

[zachkirlew]

@BenFradet Tests fixed

[cb372]

The tests were running for 45 minutes. I've just cancelled them and restarted 🤞

[cb372]

LGTM. Thanks for the contribution!