Update dependencies #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
changed the title
|
Addresses #56 |
ghost
changed the title
| import PgpKeys.gpgCommand | ||
|
|
||
| val dev = Seq(Dev("47 Degrees (twitter: @47deg)", "47 Degrees")) | ||
| val gh = GitHubSettings("com.fortysevendeg", "github4s", "47 Degrees", mit) |
There was a problem hiding this comment.
We still need these settings for releasing purposes. Can we get these back?
build.sbt
Outdated
| @@ -32,8 +27,7 @@ lazy val buildSettings = Seq( | |||
| sharedCommonSettings ++ | |||
| miscSettings ++ | |||
| sharedReleaseProcess ++ | |||
| credentialSettings ++ | |||
| sharedPublishSettings(gh, dev) | |||
There was a problem hiding this comment.
Same here, sharedPublishSettings is needed.
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 27 27
Lines 402 402
Branches 3 3
=======================================
Hits 345 345
Misses 57 57
Continue to review full report at Codecov.
|
|
@juanpedromoreno just added the publish settings back, let's wait for Travis to give us 💚 and we can merge this. |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.