Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes CreateLabel integration test #550

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fixes CreateLabel integration test #550

merged 1 commit into from
Sep 17, 2020

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno added bug Something isn't working tests Improves or modifies tests labels Sep 17, 2020
@juanpedromoreno juanpedromoreno mentioned this pull request Sep 17, 2020
Merged
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #550 into master will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
+ Coverage   90.79%   91.24%   +0.44%     
==========================================
  Files          24       24              
  Lines         641      651      +10     
  Branches        1        1              
==========================================
+ Hits          582      594      +12     
+ Misses         59       57       -2
Impacted Files Coverage Δ
github4s/src/main/scala/github4s/Encoders.scala 96.55% <100.00%> (+0.12%) ⬆️
...cala/github4s/interpreters/IssuesInterpreter.scala 100.00% <100.00%> (ø)
...ub4s/src/main/scala/github4s/http/HttpClient.scala 96.96% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d873e66...2001c9d. Read the comment docs.

bilki
bilki approved these changes Sep 17, 2020
View reviewed changes
Copy link

@bilki bilki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@juanpedromoreno juanpedromoreno merged commit 1c8c21b into master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilki bilki bilki approved these changes

Assignees
No one assigned
Labels
bug Something isn't working tests Improves or modifies tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanpedromoreno @bilki