Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala: 2.12.12/2.13.4, sbt-mdoc: 2.2.16 #601

Merged
merged 3 commits into from
Jan 27, 2021

Conversation

sloshy
Copy link
Contributor

@sloshy sloshy commented Jan 26, 2021

Supersedes #599. Updates sbt-mdoc and also updates Scala to the latest (as of today) versions for cross-building. The reason that branch was failing, I guess had something to do with the old version of Scala 2.12 we were cross-building for. As per: https://gitter.im/scalameta/mdoc?at=60107e009fa6765ef8db3dad

EDIT: The Scala 2.12 version was not able to be updated all the way to 2.12.13, as that breaks compatibility with sbt-coverage as linked to below. For now, this is the lowest version that will allow sbt-mdoc to work without breaking other plugins.

@github-actions github-actions bot added the dependency-update A dependency version update label Jan 26, 2021
@sloshy sloshy marked this pull request as draft January 26, 2021 20:54
@sloshy
Copy link
Contributor Author

sloshy commented Jan 26, 2021

Unfortunately this is still failing due to scoverage/sbt-scoverage#319
sbt-coverage does not support the latest Scala versions. When this issue is updated and a solution is available, we can go forward with updating Scala versions.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #601 (803e031) into master (cd5db58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #601   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files          25       25           
  Lines         614      614           
  Branches        4        4           
=======================================
  Hits          554      554           
  Misses         60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5db58...803e031. Read the comment docs.

@sloshy sloshy marked this pull request as ready for review January 26, 2021 21:40
@sloshy
Copy link
Contributor Author

sloshy commented Jan 26, 2021

For now I've downgraded Scala to 2.12.12 from 2.12.13. It's still an upgrade, but not all-the-way. 2.13.4 still works.

@sloshy sloshy changed the title Update Scala: 2.12.13/2.13.4, sbt-mdoc: 2.2.16 Update Scala: 2.12.12/2.13.4, sbt-mdoc: 2.2.16 Jan 26, 2021
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sloshy sloshy merged commit fdeda48 into master Jan 27, 2021
@sloshy sloshy deleted the dep/scala-2-12-13-and-2-13-4 branch January 27, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-update A dependency version update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants