Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds some optional fields to the User model #61

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Adds some optional fields to the User model #61

merged 1 commit into from
Mar 22, 2017

Conversation

fedefernandez
Copy link
Contributor

Please @juanpedromoreno, could you review? Thanks!

@fedefernandez fedefernandez changed the title Adds some optional field to User model Adds some optional fields to User model Mar 22, 2017
@fedefernandez fedefernandez changed the title Adds some optional fields to User model Adds some optional fields to the User model Mar 22, 2017
juanpedromoreno
juanpedromoreno approved these changes Mar 22, 2017
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Mar 22, 2017 •
edited
Loading

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files          27       27           
  Lines         402      402           
  Branches        3        3           
=======================================
  Hits          345      345           
  Misses         57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087d5ae...ba8875c. Read the comment docs.

@fedefernandez fedefernandez merged commit d9d2d4e into master Mar 22, 2017
@fedefernandez fedefernandez deleted the ff-adds-some-optional-fields-to-user branch March 22, 2017 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedefernandez @codecov-io @juanpedromoreno