-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds some git methods #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 79.1% 79.43% +0.32%
==========================================
Files 27 31 +4
Lines 402 457 +55
Branches 2 2
==========================================
+ Hits 318 363 +45
- Misses 84 94 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding job!
I've added some minor comments but changes look great. Thanks!
} | ||
} | ||
|
||
it should "return the multiple reference" in { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"return multiple references"?
implicit def decodeListRef(implicit D: Decoder[Ref]): Decoder[NonEmptyList[Ref]] = { | ||
|
||
def decodeCursor(partialList: Option[NonEmptyList[Ref]], cursor: HCursor): Decoder.Result[NonEmptyList[Ref]] = | ||
cursor.as[Ref] match { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
|
||
Decoder.instance { c ⇒ | ||
c.as[Ref] match { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bimap
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible because the left function result is encapsulated inside a Left
in the bimap
and we want to return an Either
* Refactorizes the Git ops to GitData * Adds new tests for Git ops * Disables minimum coverage for scalaz and js modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds some needed
git
methods for adding new content to a GitHub repo.Please @juanpedromoreno, could you review? Thanks