Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git tag feature #71

Merged
merged 2 commits into from
Mar 31, 2017
Merged

Git tag feature #71

merged 2 commits into from
Mar 31, 2017

Conversation

fedefernandez
Copy link
Contributor

Fixes #68

Also adds the createReference op

Please @juanpedromoreno could you review? Thanks!

@codecov-io
Copy link

codecov-io commented Mar 31, 2017

Codecov Report

Merging #71 into master will decrease coverage by 1.3%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   80.04%   78.74%   -1.31%     
==========================================
  Files          34       34              
  Lines         471      795     +324     
  Branches        2        4       +2     
==========================================
+ Hits          377      626     +249     
- Misses         94      169      +75
Impacted Files Coverage Δ
.../main/scala/github4s/free/domain/PullRequest.scala 100% <ø> (ø) ⬆️
.../src/main/scala/github4s/free/domain/GitData.scala 0% <ø> (ø) ⬆️
.../main/scala/github4s/free/algebra/GitDataOps.scala 33.33% <0%> (-9.53%) ⬇️
...4s/shared/src/main/scala/github4s/GithubAPIs.scala 95.55% <100%> (+0.31%) ⬆️
...s/shared/src/main/scala/github4s/api/GitData.scala 100% <100%> (ø) ⬆️
...cala/github4s/free/interpreters/Interpreters.scala 84.44% <33.33%> (-3.32%) ⬇️
...thub4s/shared/src/main/scala/github4s/Github.scala 81.81% <0%> (-1.52%) ⬇️
...ub4s/shared/src/main/scala/github4s/Decoders.scala 95.09% <0%> (-0.74%) ⬇️
...scala/github4s/HttpRequestBuilderExtensionJS.scala 0% <0%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cd8b9...fa50a61. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
giphy 12

Codecov and Travis are complaining though :P

case object PRFilterSortUpdated extends PRFilterState("updated")
case object PRFilterSortPopularity extends PRFilterState("popularity")
case object PRFilterSortLongRunning extends PRFilterState("long-running")
case object PRFilterSortCreated extends PRFilterSort("created")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@fedefernandez fedefernandez merged commit d3c1079 into master Mar 31, 2017
@fedefernandez fedefernandez deleted the ff-issue-68-git-tag-feature branch March 31, 2017 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants