-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Serialization of default values in createSerializer
#642
fix: Serialization of default values in createSerializer
#642
Conversation
@hugotiger is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
1c1b460
to
978631a
Compare
createSerializer
978631a
to
f6ca270
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks! Could you change back the base branch to next for this one? It's not a breaking change, so it can be published on the v1 release line. I pushed a fix for the types to let parsers know they can have a default value. |
59b2963
to
0d1351f
Compare
Awesome! Thanks for the help ✌️ Rebased now and updated the description of the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test is failing, see https://github.com/47ng/nuqs/actions/runs/10936702232/job/30378534527#step:7:90
I'm not able to reproduce it locally 🤔 Could it be some caching issue in the action? For context when I run |
I checked again now and it seems as if the CI was running on some previous commit. Could you do a rerun? |
Thanks! |
🎉 This PR is included in version 1.19.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
When using parsers in
createSerializer
it would not respect theclearOnDefault
option properly when serializing, thus adding key-value pairs to the string that shouldn't be there.An example:
Closes #641.