generated from chiffre-io/template-library
-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add loader feature #818
Open
franky47
wants to merge
5
commits into
next
Choose a base branch
from
feat/loaders
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
franky47
force-pushed
the
feat/loaders
branch
from
December 24, 2024 10:33
289c601
to
d402ae8
Compare
franky47
force-pushed
the
feat/loaders
branch
from
December 26, 2024 10:34
b48fc8f
to
69056d9
Compare
franky47
force-pushed
the
feat/loaders
branch
from
December 26, 2024 21:49
5683d48
to
0c272cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we have the cache feature in Next.js app router to parse the incoming
searchParams
page prop and provide it to the rest of the RSC tree (via React'scache
function, which is a hack but not the subject of this PR), other frameworks lacked the ability to parse an incoming request's search params and get the same kind of type-safe object back (without the caching part).This PR introduces the
createLoader
function, a factory that takes in a search params descriptor object (a "parsers map" as we call it internally), and returns aload
function. That function can then process a lot of different kinds of inputs:search
partRecord<string, string | string[] | undefined>
)Compatibility
Request
object)getServerSideProps
(needs a test)searchParams
prop (async in Next 15 -> good for PPR)Tasks