Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When reading a configuration file that doesn't exist the exception handler returns {} which breaks configuration and causes Buster to crash. #13

Closed
jeffschwartz opened this issue Jan 5, 2019 · 0 comments
Closed

When reading a configuration file that doesn't exist the exception handler returns {} which breaks configuration and causes Buster to crash. #13

jeffschwartz opened this issue Jan 5, 2019 · 0 comments
Assignees
@jeffschwartz
Labels
bug Something isn't working
Milestone
v0.2.3

Comments

@jeffschwartz
Copy link
Collaborator

jeffschwartz commented Jan 5, 2019 •
edited
Loading

It should return false to fulfill the promise and checked to determine if the file should then be converted to JSON.
jeffschwartz added a commit that referenced this issue Jan 5, 2019
@jeffschwartz
now returning false in exception handler when attempting to read a file
638d5a8 
that doesn't exist - addresses issue #13
@jeffschwartz jeffschwartz self-assigned this Jan 5, 2019
@jeffschwartz jeffschwartz added the bug Something isn't working label Jan 5, 2019
@jeffschwartz jeffschwartz added this to the v0.2.3 milestone Jan 5, 2019
@jeffschwartz jeffschwartz changed the title When attempting to read a file that doesn't exist the exception handler returns {} which breaks configuration. When attempting to read a file that doesn't exist the exception handler returns {} which breaks configuration and causes Buster to crash. Jan 5, 2019
@jeffschwartz jeffschwartz changed the title When attempting to read a file that doesn't exist the exception handler returns {} which breaks configuration and causes Buster to crash. When reading a configuration file that doesn't exist the exception handler returns {} which breaks configuration and causes Buster to crash. Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffschwartz jeffschwartz

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.3
Development

No branches or pull requests
1 participant
@jeffschwartz