Provide only one callback for error (simplify)

4d · Jan 29, 2024 · 556115b · 556115b
1 parent ae0f6a2
commit 556115b
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/qmobiledatasync/src/main/java/com/qmobile/qmobiledatasync/viewmodel/ActionViewModel.kt b/qmobiledatasync/src/main/java/com/qmobile/qmobiledatasync/viewmodel/ActionViewModel.kt
@@ -71,7 +71,6 @@ class ActionViewModel(apiService: ApiService) : BaseViewModel() {
         imagesToUpload: Map<String, Result<RequestBody>>,
         onImageUploaded: (parameterName: String, receivedId: String) -> Unit,
         onImageFailed: (parameterName: String, throwable: Throwable) -> Unit,
-        onError: () -> Unit,
         onAllUploadFinished: () -> Unit
     ) {
         actionRepository.uploadImage(
@@ -87,11 +86,8 @@ class ActionViewModel(apiService: ApiService) : BaseViewModel() {
                         }
                     }
                 } else {
-                    error?.let {
-                        onImageFailed(parameterName, it)
-                    }
+                    onImageFailed(parameterName, error ?: UnknownError("Failed to upload image without any known error"))
                     treatFailure(response, error, "ActionViewModel", ToastMessage.Type.ERROR)
-                    onError()
                 }
             }
         ) {