Do not hide image upload response decoding errors

4d · Jan 30, 2024 · cecba16 · cecba16
1 parent 556115b
commit cecba16
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/qmobiledatasync/src/main/java/com/qmobile/qmobiledatasync/viewmodel/ActionViewModel.kt b/qmobiledatasync/src/main/java/com/qmobile/qmobiledatasync/viewmodel/ActionViewModel.kt
@@ -15,6 +15,7 @@ import com.qmobile.qmobileapi.utils.retrieveResponseObject
 import com.qmobile.qmobiledatasync.app.BaseApp
 import com.qmobile.qmobiledatasync.toast.ToastMessage
 import okhttp3.RequestBody
+import org.json.JSONException
 import timber.log.Timber
 
 class ActionViewModel(apiService: ApiService) : BaseViewModel() {
@@ -77,11 +78,18 @@ class ActionViewModel(apiService: ApiService) : BaseViewModel() {
             imagesToUpload,
             { isSuccess, parameterName, response, error ->
                 if (isSuccess) {
-                    response?.body()?.let { responseBody ->
-
-                        retrieveJSONObject(responseBody.string())?.let { responseJson ->
-                            responseJson.getSafeString("ID")?.let { id ->
-                                onImageUploaded(parameterName, id)
+                    when(val responseBody = response?.body()) {
+                        null -> onImageFailed(parameterName, JSONException("Failed to get image upload ID from null server response"))
+                        else -> {
+                            val responseBodyString = responseBody.string()
+                            when (val responseJson = retrieveJSONObject(responseBodyString)) {
+                                null -> onImageFailed(parameterName, JSONException("Failed to get image upload ID from expected JSON response $responseBodyString"))
+                                else -> {
+                                    when(val id = responseJson.getSafeString("ID")) {
+                                        null -> onImageFailed(parameterName, JSONException("Failed to get image upload ID from response $responseJson"))
+                                        else -> onImageUploaded(parameterName, id)
+                                    }
+                                }
                             }
                         }
                     }