Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev assign roles section bug fixes - MERGE ONTO DEV #78

Merged
merged 5 commits into from
Sep 2, 2021

Conversation

bgunnar5
Copy link
Collaborator

@bgunnar5 bgunnar5 commented Sep 2, 2021

This branch has bug fixes for the config page that include:

  • fixing bug with deleting a role that ruined state for the assignment panel
  • fixing bug with adding new role that disabled ban/remove buttons and dropdown role selector in the assignment panel

This branch also added the Errors common component to the config page in 3 places:

  • role configuration section
  • role assignment section
  • banned users section
    Note: backend changes had to be made to accommodate the new error system for config page.

…d made the dropdown change state when new role added
… maintains it's form instead of not loading anything
Added 3 separate error message sections for the config page: configErrors, assignErrors, and banErrors. These are split into three so there is one for each respective section.
@bgunnar5 bgunnar5 merged commit c3e8327 into dev Sep 2, 2021
@bgunnar5 bgunnar5 deleted the dev-assign-roles-section-bug-fixes branch September 2, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant