You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Like it says, if we create a socket in StatsdClient::from_udp_host, create it in non-blocking mode. We could also potentially support some sort of config object here to pass in. But, I don't think that's really needed since callers can always just use the StatsdClient::from_sink method for more control.
The text was updated successfully, but these errors were encountered:
Update the actual code in StatsdClient::from_udp_host
Update StatsdClient::from_udp_host docs to indicate that sockets are created in non-blocking mode
Update UdpMetricSink::from docs to indicate that the non-blocking example is done by default in StatsdClient::from_udp_host
Update lib.rs and README.md to indicate that sockets are created in non-blocking mode (maybe remove that section about creating a non-blocking socket?)
Change tests to just use from_udp_host and remove the non-blocking special cases
…g mode
Create UDP sockets in non-blocking mode by default. This should result in
a minimal behavior change for callers of the library. Callers wishing to
restore the old behavior (blocking) can do so by creating a custom
UdpMetricSink instance.
Fixes#14
Create UDP sockets in non-blocking mode by default. This should
result in a minimal behavior change for callers of the library.
Callers wishing to restore the old behavior (blocking) can do so
by creating a custom UdpMetricSink instance.
Fixes#14
Like it says, if we create a socket in
StatsdClient::from_udp_host
, create it in non-blocking mode. We could also potentially support some sort of config object here to pass in. But, I don't think that's really needed since callers can always just use theStatsdClient::from_sink
method for more control.The text was updated successfully, but these errors were encountered: