Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ConsoleMetricSink #33

Closed
56quarters opened this issue Dec 19, 2016 · 0 comments
Closed

Deprecate ConsoleMetricSink #33

56quarters opened this issue Dec 19, 2016 · 0 comments
Assignees
@56quarters
Labels
cleanup enhancement
Milestone
0.9.0

Comments

@56quarters
Copy link
Owner

It's about two lines of code and clutters the global namespace.
@56quarters 56quarters added this to the 0.10.0 milestone Dec 19, 2016
56quarters added a commit that referenced this issue Dec 21, 2016
@56quarters
Deprecate log and console metric sinks.
9c04d54 
Doing this because they are trivial for users to implement themselves and
they just clutter up the namespace of the lib as well as add extra deps.

Fixes #32
Fixes #33
@56quarters 56quarters mentioned this issue Dec 21, 2016
Merged
@56quarters 56quarters self-assigned this Dec 21, 2016
@56quarters 56quarters modified the milestones: 0.9.0, 0.10.0 Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@56quarters 56quarters

Labels
cleanup enhancement
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@56quarters