Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more things for more advanced sink impl cases #206

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Expose more things for more advanced sink impl cases #206

merged 2 commits into from
Apr 25, 2024

Conversation

mlowicki
Copy link
Contributor

Related to #205.

@mlowicki mlowicki mentioned this pull request Apr 24, 2024
Closed
56quarters
56quarters reviewed Apr 24, 2024
View reviewed changes
Copy link
Owner

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small comment

cadence/src/sinks/mod.rs Outdated Show resolved Hide resolved
@mlowicki mlowicki marked this pull request as ready for review April 25, 2024 07:20
@56quarters 56quarters merged commit d5a01a9 into 56quarters:master Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@56quarters 56quarters Awaiting requested review from 56quarters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlowicki @56quarters