Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove debug log in send_metric #7

Closed
wants to merge 1 commit into from
Closed

remove debug log in send_metric #7

wants to merge 1 commit into from

Conversation

ngaut
Copy link
Contributor

@ngaut ngaut commented Jun 4, 2016

No description provided.

@coveralls
Copy link

coveralls commented Jun 4, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-4.5%) to 67.265% when pulling 5bb57aa on ngaut:ngaut/clean-up into 95cf7eb on tshlabs:master.

@56quarters
Copy link
Owner

56quarters commented Jun 5, 2016 •
edited
Loading

Hi @ngaut,

Thanks for the PR! Could you provide some explanation of why the debug! logging call should be removed as part of the commit message? Happy to merge after that. Thanks!

@ngaut
Copy link
Contributor Author

ngaut commented Jun 7, 2016

Hi @56quarters:
Thanks. We are using cadence heavily. There are too many debug messages output by cadence(The capacity of log file was 37G after 20 hours, most of the log messages were generated by cadence ). As a library, i think we should keep it clean.

@56quarters
Copy link
Owner

Merged in 9c2fc02, thanks!

@56quarters 56quarters closed this Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngaut @coveralls @56quarters