Convert UDS writers to use UnixDatagram instead of UnixStream #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if you'd like me to convert the TODO into a GitHub Issue. |
56quarters
requested changes
Sep 25, 2019
56quarters
requested changes
Sep 26, 2019
56quarters
approved these changes
Sep 26, 2019
|
Looks good. Rebase to a single commit and I'll merge. Thanks! |
|
Nm, I did the merge + rebase |
|
Thanks! Could you do a cargo release with this added in? |
|
It'll be a little while before I'm ready to do the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86 used the wrong UDS protocol. This PR uses the correct protocol along with some cleanup.
Fixes #88