Skip to content

Commit

Permalink
fix entry sorter metrics (pingcap#396)
Browse files Browse the repository at this point in the history
  • Loading branch information
amyangfei authored Mar 29, 2020
1 parent 694730d commit 5a2f454
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions cdc/puller/entry_sorter.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ func (es *EntrySorter) Run(ctx context.Context) {
case <-ctx.Done():
return
case <-time.After(time.Minute):
entrySorterResolvedChanSizeGauge.WithLabelValues(captureID, changefeedID).Set(float64(len(es.output)))
entrySorterOutputChanSizeGauge.WithLabelValues(captureID, changefeedID).Set(float64(len(es.resolvedCh)))
entrySorterResolvedChanSizeGauge.WithLabelValues(captureID, changefeedID).Set(float64(len(es.resolvedCh)))
entrySorterOutputChanSizeGauge.WithLabelValues(captureID, changefeedID).Set(float64(len(es.output)))
}
}
}()
Expand Down
10 changes: 5 additions & 5 deletions ticdc.json
Original file line number Diff line number Diff line change
Expand Up @@ -1289,10 +1289,10 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(ticdc_puller_entry_sorter_output_chan_size{changefeed=\"$changefeed\",capture=\"$capture\"}) by (instance, table)",
"expr": "sum(ticdc_puller_entry_sorter_output_chan_size{changefeed=\"$changefeed\",capture=\"$capture\"}) by (instance)",
"format": "time_series",
"intervalFactor": 1,
"legendFormat": "{{instance}}-{{table}}",
"legendFormat": "{{instance}}",
"refId": "A"
}
],
Expand Down Expand Up @@ -1383,10 +1383,10 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(ticdc_puller_entry_sorter_resolved_chan_size{changefeed=\"$changefeed\",capture=\"$capture\"}) by (instance, table)",
"expr": "sum(ticdc_puller_entry_sorter_resolved_chan_size{changefeed=\"$changefeed\",capture=\"$capture\"}) by (instance)",
"format": "time_series",
"intervalFactor": 1,
"legendFormat": "{{instance}}-{{table}}",
"legendFormat": "{{instance}}",
"refId": "A"
}
],
Expand Down Expand Up @@ -2780,4 +2780,4 @@
"title": "ticdc",
"uid": "YiGL8hBZz",
"version": 39
}
}

0 comments on commit 5a2f454

Please sign in to comment.