Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SNS component #44

Merged
merged 4 commits into from
Nov 16, 2024
Merged

Add SNS component #44

merged 4 commits into from
Nov 16, 2024

Conversation

5ouma
Copy link
Owner

@5ouma 5ouma commented Nov 16, 2024

⚠️ Issue

close #


✏️ Description

Render SNS icon and link.


🔄 Type of the Change

  • 🎉 New Feature
  • 🧰 Bug
  • 🛡️ Security
  • 📖 Documentation
  • 🏎️ Performance
  • 🧹 Refactoring
  • 🧪 Testing
  • 🔧 Maintenance
  • 🎽 CI
  • 🧠 Meta

5ouma added 3 commits November 16, 2024 14:36
@5ouma
feat(component): Show SNS link
3dc4460 
Access SNS links.
@5ouma
chore(component): Add Astrobook for sns
50f544b 
Preview all variants with icons and ids.
@5ouma
test(component): Add sns unit test
775a13b 
Check whether the components are rendered as expected.
@5ouma 5ouma requested a review from Copilot November 16, 2024 05:38
@prlabeler prlabeler bot added the 🎉 New Feature Introduce a new feature label Nov 16, 2024
Copilot
Copilot AI reviewed Nov 16, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 suggestion.

Files not reviewed (2)
  • src/components/SNS/SNS.astro: Language not supported
  • src/components/SNS/snapshots/SNS.test.ts.snap: Language not supported

src/components/SNS/SNS.test.ts Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0e985bf) to head (36443b4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        17    +2     
  Lines          188       228   +40     
  Branches        20        21    +1     
=========================================
+ Hits           188       228   +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024 •
edited
Loading

🔦 Lighthouse Result

performance accessibility best-practices seo
🟧 75 🟢 100 🟢 100 🟧 63
📊 Score Scale
Fail Average Pass
🔺 0-49 🟧 50-89 🟢 90-100

@5ouma @Copilot
refactor(component): Don't use Object.entries()
36443b4 
Looping a simple array with it is not correct.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Souma <101255979+5ouma@users.noreply.github.com>
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 16, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new SNS component in SNS.astro, which renders user profile links based on service names and user IDs. It includes a new story file for Storybook that defines various social media platforms and their respective configurations. Additionally, a test file is added to validate the component's functionality with both valid and invalid inputs. The changes also include the creation of a story.ts file that exports constants representing different social media services.

Changes

File Change Summary
src/components/SNS/SNS.astro Introduced SNS component that renders user profile links based on service name and user ID.
src/components/SNS/SNS.stories.ts Added Storybook stories for the SNS component, defining exports for various social media platforms.
src/components/SNS/SNS.test.ts Created unit tests for the SNS component, validating both valid and invalid service and ID inputs.
src/components/SNS/story.ts Introduced constants for different social media services, typed as Props.

Possibly related PRs

  • Add contact component #9: The Contact component also renders a link to a user's profile based on a service name and user ID, similar to the SNS component in the main PR.
  • Hover to change the color #21: Enhancements to the Contact component's styling, including hover effects, relate to the visual appeal and user interaction aspects of the SNS component.
  • Add card component #43: The Card component generates and displays a QR code linked to a specified URL, which is conceptually similar to the SNS component's functionality of linking to user profiles.

Warning

Rate limit exceeded

@5ouma has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 42 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 0e985bf and 36443b4.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@5ouma 5ouma merged commit 9d03989 into main Nov 16, 2024
11 checks passed
@5ouma 5ouma deleted the feat-component-sns branch November 16, 2024 05:45
@github-actions github-actions bot mentioned this pull request Nov 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels
🎉 New Feature Introduce a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@5ouma