Skip to content

Commit

Permalink
Remove jQuery from repo migrate page (go-gitea#29219)
Browse files Browse the repository at this point in the history
- Switched to plain JavaScript
- Tested the repo migrate functionality and it works as before

# Demo using JavaScript without jQuery

![action](https://github.com/go-gitea/gitea/assets/20454870/44ad134b-832e-44b8-8e77-7cc8603d95fe)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
  • Loading branch information
yardenshoham and silverwind authored Feb 17, 2024
1 parent 3da2c63 commit 5e1bf3e
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions web_src/js/features/repo-migrate.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
import $ from 'jquery';
import {hideElem, showElem} from '../utils/dom.js';
import {GET, POST} from '../modules/fetch.js';

const {appSubUrl} = window.config;

export function initRepoMigrationStatusChecker() {
const $repoMigrating = $('#repo_migrating');
if (!$repoMigrating.length) return;
const repoMigrating = document.getElementById('repo_migrating');
if (!repoMigrating) return;

$('#repo_migrating_retry').on('click', doMigrationRetry);
document.getElementById('repo_migrating_retry').addEventListener('click', doMigrationRetry);

const task = $repoMigrating.attr('data-migrating-task-id');
const task = repoMigrating.getAttribute('data-migrating-task-id');

// returns true if the refresh still need to be called after a while
// returns true if the refresh still needs to be called after a while
const refresh = async () => {
const res = await GET(`${appSubUrl}/user/task/${task}`);
if (res.status !== 200) return true; // continue to refresh if network error occurs
Expand All @@ -21,7 +20,7 @@ export function initRepoMigrationStatusChecker() {

// for all status
if (data.message) {
$('#repo_migrating_progress_message').text(data.message);
document.getElementById('repo_migrating_progress_message').textContent = data.message;
}

// TaskStatusFinished
Expand All @@ -37,7 +36,7 @@ export function initRepoMigrationStatusChecker() {
showElem('#repo_migrating_retry');
showElem('#repo_migrating_failed');
showElem('#repo_migrating_failed_image');
$('#repo_migrating_failed_error').text(data.message);
document.getElementById('repo_migrating_failed_error').textContent = data.message;
return false;
}

Expand All @@ -59,6 +58,6 @@ export function initRepoMigrationStatusChecker() {
}

async function doMigrationRetry(e) {
await POST($(e.target).attr('data-migrating-task-retry-url'));
await POST(e.target.getAttribute('data-migrating-task-retry-url'));
window.location.reload();
}

0 comments on commit 5e1bf3e

Please sign in to comment.