Skip to content

Commit

Permalink
Deduplicate translations for contributors graph (go-gitea#29256)
Browse files Browse the repository at this point in the history
I have implemented three graph pages
([contributors](go-gitea#27882), [code
frequency](go-gitea#29191) and [recent
commits](go-gitea#29210)) and they have
all same page title as the tab name so I decided to use same
translations for them. This PR is for contributors graph. Other PR's
have their own respective commits.

(cherry picked from commit 39a77d9)
  • Loading branch information
sahinakkaya authored and earl-warren committed Feb 19, 2024
1 parent c7c20ff commit 8125fe0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions options/locale/locale_en-US.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2023,12 +2023,10 @@ activity.git_stats_and_deletions = and
activity.git_stats_deletion_1 = %d deletion
activity.git_stats_deletion_n = %d deletions

contributors = Contributors
contributors.contribution_type.filter_label = Contribution type:
contributors.contribution_type.commits = Commits
contributors.contribution_type.additions = Additions
contributors.contribution_type.deletions = Deletions
contributors.what = contributions

search = Search
search.search_repo = Search repository
Expand Down Expand Up @@ -2654,6 +2652,7 @@ component_loading = Loading %s...
component_loading_failed = Could not load %s
component_loading_info = This might take a bit…
component_failed_to_load = An unexpected error happened.
contributors.what = contributions
[org]
org_name_holder = Organization Name
Expand Down
2 changes: 1 addition & 1 deletion routers/web/repo/contributors.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const (

// Contributors render the page to show repository contributors graph
func Contributors(ctx *context.Context) {
ctx.Data["Title"] = ctx.Tr("repo.contributors")
ctx.Data["Title"] = ctx.Tr("repo.activity.navbar.contributors")

ctx.Data["PageIsActivity"] = true
ctx.Data["PageIsContributors"] = true
Expand Down
4 changes: 2 additions & 2 deletions templates/repo/contributors.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
data-locale-contribution-type-commits="{{ctx.Locale.Tr "repo.contributors.contribution_type.commits"}}"
data-locale-contribution-type-additions="{{ctx.Locale.Tr "repo.contributors.contribution_type.additions"}}"
data-locale-contribution-type-deletions="{{ctx.Locale.Tr "repo.contributors.contribution_type.deletions"}}"
data-locale-loading-title="{{ctx.Locale.Tr "graphs.component_loading" (ctx.Locale.Tr "repo.contributors.what")}}"
data-locale-loading-title-failed="{{ctx.Locale.Tr "graphs.component_loading_failed" (ctx.Locale.Tr "repo.contributors.what")}}"
data-locale-loading-title="{{ctx.Locale.Tr "graphs.component_loading" (ctx.Locale.Tr "graphs.contributors.what")}}"
data-locale-loading-title-failed="{{ctx.Locale.Tr "graphs.component_loading_failed" (ctx.Locale.Tr "graphs.contributors.what")}}"
data-locale-loading-info="{{ctx.Locale.Tr "graphs.component_loading_info"}}"
data-locale-component-failed-to-load="{{ctx.Locale.Tr "graphs.component_failed_to_load"}}"
>
Expand Down

0 comments on commit 8125fe0

Please sign in to comment.