Skip to content

Commit

Permalink
feat(plugins): convert slick.draggablegrouping to vanillaJS (#744)
Browse files Browse the repository at this point in the history
- fix ESLint for Cypress
- also remove jQuery from package.json list of dependencies
  • Loading branch information
ghiscoding authored Apr 30, 2023
1 parent b3a6575 commit 59b0d2e
Show file tree
Hide file tree
Showing 7 changed files with 327 additions and 197 deletions.
11 changes: 8 additions & 3 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
{
"extends": "eslint:recommended",
"extends": [
"eslint:recommended",
"plugin:cypress/recommended"
],
"env": {
"browser": true,
"es2015": true
"es2015": true,
"node": true
},
"globals": {
"Slick": true
"Slick": true,
"Sortable": true
},
"rules": {
"no-prototype-builtins": [0]
Expand Down
3 changes: 2 additions & 1 deletion examples/example-external-headersort.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ <h2>Demonstrates:</h2>
{id: "effort-driven", name: "Effort Driven", sortable: false, width: 80, minWidth: 20, maxWidth: 80, cssClass: "cell-effort-driven", field: "effortDriven"}
];

function setupColumnReorder(grid, $headers, headerColumnWidthDiff, setColumns, setupColumnResize, columns, getColumnIndex, uid, trigger) {
function setupColumnReorder(grid, headers, headerColumnWidthDiff, setColumns, setupColumnResize, columns, getColumnIndex, uid, trigger) {
var $headers = $(headers);
$headers.filter(":ui-sortable").sortable("destroy");
$headers.sortable({
//cancel: '#' + uid + 'title',
Expand Down
50 changes: 39 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"release": "node ./scripts/release.js --create-release github"
},
"dependencies": {
"jquery": ">=3.0.0",
"sortablejs": "^1.15.0"
},
"devDependencies": {
Expand All @@ -48,6 +47,7 @@
"cypress": "^9.7.0",
"dotenv": "^16.0.2",
"eslint": "^8.22.0",
"eslint-plugin-cypress": "^2.13.3",
"fs-extra": "^10.1.0",
"git-url-parse": "^13.1.0",
"http-server": "^13.0.2",
Expand Down
Loading

0 comments on commit 59b0d2e

Please sign in to comment.