Editors Fail With Slick.RowSelectionModel({selectActiveRow: true})

[cpeter0]

Modify examples/example-checkbox-row-select.html line 89 to grid.setSelectionModel(new Slick.RowSelectionModel({selectActiveRow: true})); causes editing of cells to fail. Works in original SlickGrid.

[cpeter0]

Apparently has something to do with line 90 grid.registerPlugin(checkboxSelector); If this is commented out the check boxes appear and are functional except for "select all rows" checkbox in grid header.

[Aibric]

I have the same problem ... ...

[6pac]

will try to look at this soon

[6pac]

This is a really complicated bug, unfortunately, to do with active cell selection.
It will probably take 6 to 10 hours to fix at some stage, and will involve reworking all the active cell logic for the grid.

I can't even work out a quick patch yet, but if I do I'll post it.

[ghiscoding]

I have a similar problem but not sure if it's the same issue. If I use Slick.CheckboxSelectColumn with any Inline Editor, when I click on a cell that is supposed to be editable the row selection kicks in and cancels out the editor.

Is there any known workaround for something similar?
I mainly want to use Inline Editor with Row Selection

EDIT
By troubleshooting it, I found out that the cancellation of the editor is caused by this line (shown below)

// this optimisation causes trouble - MLeibman #329
//if (activeCellChanged) {
if (!suppressActiveCellChangedEvent) { trigger(self.onActiveCellChanged, getActiveCell()); }
//}

EDIT 2
I got the desired effect by changing 1 line of code (shown below). The new effect is to not cancel editing and not do a row selection when the cell has an inline editor. So basically, if the cell has an editor, it does the editing and no row selection happens, however if the cell doesn't have any editor, it will do a row selection has usual which is what I would expect the grid to work.

So here's the 1 line of code that I changed (I added true as the 4th argument, which the argument is a flag named suppressActiveCellChangedEvent). Here is the SlickGrid line (shown below) and see below for the change

// this optimisation causes trouble - MLeibman #329
//if ((activeCell != cell.cell || activeRow != cell.row) && canCellBeActive(cell.row, cell.cell)) {
if (canCellBeActive(cell.row, cell.cell)) {
  if (!getEditorLock().isActive() || getEditorLock().commitCurrentEdit()) {
    scrollRowIntoView(cell.row, false);

    var preClickModeOn = (e.target && e.target.className === Slick.preClickClassName);
-    setActiveCellInternal(getCellNode(cell.row, cell.cell), null, preClickModeOn);
+    setActiveCellInternal(getCellNode(cell.row, cell.cell), null, preClickModeOn, true);
  }
}

Adding the last flag to true will cancel the if logic mentioned in my first edit which is this line

@6pac
Should I create a separate issue? .. or is it related to the current issue?
I can create a PR if this change is acceptable, I really need this to work in my Production App.

[ghiscoding]

Found the problem and made a PR in regards to the current issue. Made a fix to master by mistake, please disregard and look instead at the PR #241

[ghiscoding]

I believe the original issue was covered in the PR that is now merged and so we should be safe to close the issue. If there's any problem, feel free to write something here or open a new issue. Thanks