fix: regression onSelectedRowsChanged
not receiving correct caller
#980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notify
function. Previously a SlickEvent would accept a CustomEvent directly and the previous code was expecting that event to exists and override its CustomEventdetail
, however the newer approach is to always use a SlickEventData and no longer use the CustomEvent directly and this caused the regression since the SlickEventData doesn't have adetail
property but rather something like thisSlickEventData { event: { detail } }
{ detail: caller }
which we then pass to theSlickEventData
constructor so that ourcaller
isn't lost and rather reused later when triggered byonSelectedRowsChanged
below is where it changed in SlickGrid
slick.core.js
file (we can see on the right side the new behavior is to always convert to aSlickEventData
and that caused the regression)