Allow deploy without prior stage when FORCE_DEPLOY environment is true
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pattern that is used with stratus may be to `stage` in branch builds, and `deploy` in default branch builds. Upon disasters, like accidental stack deletions, retrying the default branch to re-create the infrastructure, without worrying about making a temporary branch and staging, would be a fast path to recovery.
AaronMoat
changed the title
deploy without prior stagedeploy without prior stage when FORCE_DEPLOY environment is true
72636c
approved these changes
Jul 1, 2024
internal/command/deploy.go
Outdated
| @@ -16,8 +18,18 @@ func Deploy( | |||
| logger.Title("Find existing change set") | |||
|
|
|||
| changeSet, err := client.FindExistingChangeSet(ctx, stack) | |||
|
|
|||
| if err != nil { | |||
There was a problem hiding this comment.
I'm a bit rusty, are there any scenarios where err != nil apart from the change set not existing, where we should continue to short circuit?
There was a problem hiding this comment.
Yeah, there's a few exceptional things that could be bubbled from AWS SDK calls. Would be the pattern here to define a custom error? My go is rustier (in the sense it never existed) than your stratus
There was a problem hiding this comment.
I'm too far detached to speak to idiomatic Go, but I'd be supportive of smuggling through an additional changeSet == nil, err == nil state for "change set does not exist".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pattern that is used with stratus may be to
stagein branch builds, anddeployin default branch builds.Upon disasters, like accidental stack deletions or failed changes, retrying a build on a default branch to re-create the infrastructure or roll back, without worrying about making a temporary branch and staging, would be a fast path to recovery. This PR allows this to happen if and only if stratus finds a
FORCE_DEPLOYenvironment variable set totrue.Is this worth documenting? The error message will tell you what to do in a pinch.