Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MATRIX_CONTEXT will not work if more than one property is specified in the matrix #95

Closed
KoheiKanagu opened this issue Aug 6, 2020 · 4 comments · Fixed by #97
Closed

Comments

@KoheiKanagu
Copy link

KoheiKanagu commented Aug 6, 2020

Describe the bug

The URL of the job is undefined.
スクリーンショット 2020-08-06 18 25 54

If there is only one property, then the job URL is correct.

Here are the yml and jobs that are causing the problem.

@8398a7
Copy link
Owner

8398a7 commented Aug 6, 2020

Thanks for the report.
As you mentioned, having multiple properties on the matrix won't work.
refs: https://github.com/KoheiKanagu/flutter_playground/blob/64bd6e25b843a3106e1f14dbf44b26d593250945/.github/workflows/playground.yml#L12

I will consider how to fix it.

@8398a7
Copy link
Owner

8398a7 commented Aug 7, 2020

For a simple solution to this problem it would be nice to be able to get the job_id information from the toolkit.
This has been reported in the issue.

actions/toolkit#550

@8398a7 8398a7 closed this as completed in #97 Aug 7, 2020
8398a7 added a commit that referenced this issue Aug 7, 2020
[#95] Support for multiple matrix elements
@8398a7
Copy link
Owner

8398a7 commented Aug 7, 2020

@KoheiKanagu
I came up with a workaround and I responded to it.
Can you confirm that it is behaving as expected?

It is released in v3.5.1.

@KoheiKanagu
Copy link
Author

@8398a7
Thank you for the fix.
Job's URL has come to do a great job.
スクリーンショット 2020-08-07 22 20 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants