Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove naive middleware check for a griddler path #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remove naive middleware check for a griddler path #8

wants to merge 6 commits into from

Conversation

jdurand
Copy link

@jdurand jdurand commented Oct 24, 2016

  1. Mounting Griddler is not a requirement: https://github.com/thoughtbot/griddler#installation
  2. The check didn't take domains/subdomains into account
  3. Checking for the HTTP_X_AMZ_SNS_MESSAGE_TYPE header is sufficient
  4. This actually breaks if Griddler is not mounted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdurand @Nightforge