Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FileSystem.php #12

Merged
merged 9 commits into from
Oct 30, 2021
Merged

Create FileSystem.php #12

merged 9 commits into from
Oct 30, 2021

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Oct 29, 2021

  • Current site uses some Schema properties
  • Respect system preferences for light or dark mode
  • Link at top of page to scroll to bottom, two-tier navigation with "view all" style link to page with entire site map

The Content class is becoming a bit cumbersome.

Some of the methods are for interacting with the file system, some are for interacting with Markdown, and some may or may not be working with something else. It was one thing when we were interacting with content more than interacting with the file system - adding things like titles added a lot more interaction with the file system.

Going to create a FileSystem class and see how that feels.

List of issues fixed

[Please use GitHub notation to automatically close the issues: Fixes #{issue number}]

@joshbruce joshbruce marked this pull request as ready for review October 30, 2021 18:37
@joshbruce joshbruce merged commit 6fba05b into main Oct 30, 2021
@joshbruce joshbruce deleted the working branch October 30, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant