Replace uniqid with random_bytes (#14)

* Add paragonie/random_compat to maintain PHP 5.x compatibility * Update generateNonce to use random_bytes instead of uniqid
8p · Aug 9, 2019 · 006f72d · 006f72d
1 parent 3998dae
commit 006f72d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -20,7 +20,8 @@
 
     "require": {
         "php":               ">=5.5",
-        "guzzlehttp/guzzle": ">=6.0"
+        "guzzlehttp/guzzle": ">=6.0",
+        "paragonie/random_compat": ">=2"
     },
 
     "autoload": {

diff --git a/src/EightPoints/Guzzle/WsseAuthMiddleware.php b/src/EightPoints/Guzzle/WsseAuthMiddleware.php
@@ -212,6 +212,6 @@ public function generateDigest($nonce, $createdAt, $password)
      */
     public function generateNonce()
     {
-        return base64_encode(hash('sha512', uniqid(true)));
+        return base64_encode(random_bytes(128));
     }
 }