fix binding to primitive non leaf types

99designs · May 15, 2019 · a512005 · a512005
1 parent b0cd95a
commit a512005
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/codegen/config/binder.go b/codegen/config/binder.go
@@ -349,7 +349,7 @@ func (b *Binder) TypeReference(schemaType *ast.Type, bindTarget types.Type) (ret
 		} else if hasMethod(obj.Type(), "MarshalGQL") && hasMethod(obj.Type(), "UnmarshalGQL") {
 			ref.GO = obj.Type()
 			ref.IsMarshaler = true
-		} else if underlying := basicUnderlying(obj.Type()); underlying != nil && underlying.Kind() == types.String {
+		} else if underlying := basicUnderlying(obj.Type()); def.IsLeafType() && underlying != nil && underlying.Kind() == types.String {
 			// Special case for named types wrapping strings. Used by default enum implementations.
 
 			ref.GO = obj.Type()

diff --git a/codegen/testserver/generated.go b/codegen/testserver/generated.go
diff --git a/codegen/testserver/primitive_objects_test.go b/codegen/testserver/primitive_objects_test.go
@@ -61,7 +61,7 @@ func TestPrimitiveStringObjects(t *testing.T) {
 			PrimitiveStringObject []struct {
 				Value   string
 				Doubled string
-				Len int
+				Len     int
 			}
 		}
 		c.MustPost(`query { primitiveStringObject { value, doubled, len } }`, &resp)