Move input validation into gqlparser see vektah/gqlparser#96

99designs · Feb 6, 2019 · b26b915 · b26b915
1 parent 4213186
commit b26b915
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 74 deletions.
diff --git a/codegen/args.go b/codegen/args.go
@@ -31,16 +31,6 @@ func (f *FieldArgument) Stream() bool {
 }
 
 func (b *builder) buildArg(obj *Object, arg *ast.ArgumentDefinition) (*FieldArgument, error) {
-	def := b.Schema.Types[arg.Type.Name()]
-	if !def.IsInputType() {
-		return nil, errors.Errorf(
-			"cannot use %s as argument %s because %s is not a valid input type",
-			arg.Type.String(),
-			arg.Name,
-			def.Kind,
-		)
-	}
-
 	tr, err := b.Binder.TypeReference(arg.Type, nil)
 	if err != nil {
 		return nil, err

diff --git a/codegen/directive.go b/codegen/directive.go
@@ -28,11 +28,6 @@ func (b *builder) buildDirectives() (map[string]*Directive, error) {
 
 		var args []*FieldArgument
 		for _, arg := range dir.Arguments {
-			def := b.Schema.Types[arg.Type.Name()]
-			if !def.IsInputType() {
-				return nil, errors.Errorf("%s cannot be used as argument of directive %s(%s) only input and scalar types are allowed", arg.Type, dir.Name, arg.Name)
-			}
-
 			tr, err := b.Binder.TypeReference(arg.Type, nil)
 			if err != nil {
 				return nil, err

diff --git a/codegen/errors_test.go b/codegen/errors_test.go
diff --git a/codegen/field.go b/codegen/field.go
@@ -36,18 +36,6 @@ func (b *builder) buildField(obj *Object, field *ast.FieldDefinition) (*Field, e
 		return nil, err
 	}
 
-	def := b.Schema.Types[field.Type.Name()]
-
-	if obj.Kind == ast.InputObject && !def.IsInputType() {
-		return nil, errors.Errorf(
-			"%s.%s: cannot use %s because %s is not a valid input type",
-			obj.Name,
-			field.Name,
-			def.Name,
-			def.Kind,
-		)
-	}
-
 	f := Field{
 		FieldDefinition: field,
 		Object:          obj,

diff --git a/codegen/testdata/typeinput.graphqls b/codegen/testdata/typeinput.graphqls
diff --git a/codegen/testdata/unioninput.graphqls b/codegen/testdata/unioninput.graphqls