Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation docs and examples #1018

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Federation docs and examples #1018

merged 1 commit into from
Feb 8, 2020

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Feb 8, 2020

Adds an example implementing the federation introduction server, a short recipe on how it was created and an end to end test to make sure federation doesn't get completely broken.

@marwan-at-work

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

Copy link
Contributor

@marwan-at-work marwan-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍

As a side note, it might be worth throwing a go.mod file in the example folder (or making a separate repo since sub-modules come with a big caution) so that someone go-getting gqlgen doesn't need to download the entire examples folder.

@vektah
Copy link
Collaborator Author

vektah commented Feb 8, 2020

I don't want to split the examples out into their own repo because its really hard to keep external resources in sync. Look how well it turned out for https://github.com/vektah/gqlgen-tutorials :(

In this case though, the go mod changes aren't coming from the example, but from a bit of debugging middleware I needed to debug an issue.
image

side note: Federation gateway is pretty dumb hey?

That said, these new deps are pretty tiny and shouldn't cause any issues. Its a shame go mod tidy doesn't prune test/unused deps itself. At least go doesn't build these packages, and the downloads are fast (via proxy)

@vektah vektah merged commit e289aaa into master Feb 8, 2020
@vektah vektah deleted the federation-docs branch February 8, 2020 04:36
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants