Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add a _ suffix to reserved words #105

Merged
merged 1 commit into from
May 3, 2018
Merged

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented May 3, 2018

Hows this look @ameliaikeda?

Fixes #101

Copy link

@ameliaikeda ameliaikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the schema generated map this correctly for neelance when executing queries?

@vektah
Copy link
Collaborator Author

vektah commented May 3, 2018

the neelance lib is only used for parsing the schema and parsing and validating the request. The entire execution environment is in the generated code.

eg:
https://github.com/vektah/gqlgen/blob/26ac13ffec364baf5d6db0a3d6bb613c5fba25ea/example/scalars/generated.go#L121-L149

@ameliaikeda
Copy link

Nice, thanks!

@vektah vektah merged commit 2a437c2 into master May 3, 2018
@vektah vektah deleted the keyword-input-args branch May 3, 2018 10:50
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Automatically add a _ suffix to reserved words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants