Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to godoc to the README and docsite #1147

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

ddevault
Copy link
Contributor

No description provided.

@ddevault
Copy link
Contributor Author

All of the seemingly unrelated changes are for the purpose of (1) moving it to the end of the sidebar and (2) adding a little icon that indicates it's an external link. The result looks like this:

@vektah
Copy link
Collaborator

vektah commented Apr 24, 2020

I'm not sure how useful godoc is for code generators but if even one person other person gives this a 👍 because they find it useful I'll :shipit:

@ddevault
Copy link
Contributor Author

gqlgen doesn't do all of the work for you - you still need to interact with its API from schema.resolvers.go, custom scalars, models, etc.

@vektah vektah merged commit e4c699d into 99designs:master Apr 24, 2020
@ddevault ddevault deleted the docs branch April 24, 2020 01:18
@ddevault
Copy link
Contributor Author

Thanks :)

@ddevault
Copy link
Contributor Author

ddevault commented May 5, 2020

It doesn't seem like this change was ever deployed to the website.

cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Add links to godoc to the README and docsite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants