Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent versions of
gopls
report explicit type definitions on individual slice/array/map items as a warning:redundant type from array, slice, or map composite literal
I believe this is because of the inclusion of https://golang.org/cmd/gofmt/#hdr-The_simplify_command in the checks performed by the
lsp
.The PR makes a small modification to
codegen/generated!.gotpl
template to prevent this warning from showing up in the code generated bygqlgen
.I have:
It's effectively a code-formatting change and it doesn't affect any functionality.
It's effectively a code-formatting change and it doesn't affect any functionality.