Fixing panic when non array value is passed to array type #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you share an example and detail? |
|
Thanks for the pr, a test would be the best way to give an example :) |
|
👋 Added a test to the dataloader example to demonstrate this. Essentially if you pass an object instead of an array in your query/mutation, gqlgen panics. Handling is not ideal as the field is now ignored with no errors, I imagine this will be fixed properly when @vektah introduces the new parser 🎉! For now I hope this is sufficient to prevent app's from panic-ing with malformed input, without having some kind of middleware to recover the application... |
|
Yeah that definitely should be caught by validation and give a good message to the user, but the runtime shouldn't panic. 👍 |
|
🎉 Thanks again @vektah |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
…-invalid-array-type Fixing panic when non array value is passed to array type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered a panic similar to issue #110 when passing an object to an array type.