fix #1237 remove unreachable types from generated code #1238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unreachable objects, inputs, interfaces, unions, scalars, and enums from the schema right after parsing it. It doesn't try to remove unused directives.
Existing tests did a reasonable job at covering the changes, but this does need more testing. I added
unreachable.graphql
with an object, an input, an interface, an union, a scalar, and an enum.I need feedback on what to do with built in types like Int and if this warning message makes sense:
I could use some help with the diff in the generated resolver.go code. There's some formatting issue?
I have: