Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bunch of unneeded nil checks from non-nullable graphql type unmarshalling #1243

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

lwc
Copy link
Member

@lwc lwc commented Jul 10, 2020

#1242 increased the scope of what is considered to be a nillable go type, which in turn generated a bunch of additional nil checks during unmarshalling. Nil checks are only required when the GraphQL type being bound to is allowed to be null, so this cleans that up and steals the test from #1204.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@lwc lwc merged commit 8494028 into master Jul 10, 2020
@mtibben mtibben deleted the nilable-nullable-unnmarshal branch September 6, 2021 06:05
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
…marshal

Remove a bunch of unneeded nil checks from non-nullable graphql type unmarshalling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant