Fix typo cause memory problem on upload #1246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix potentially typo that make unusual memory usage when uploaded a large file
The issue #1193 created months back
Noticed that line 67 of /graphql/handler/transport/http_form.go has potentially typo of using
MaxUploadSize
instead ofMaxMemory
func (r *Request) ParseMultipartForm(maxMemory int64) error
required max memoryThis will cause problem when max upload size set to a large number