Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo cause memory problem on upload #1246

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

arkhvoid
Copy link
Contributor

Fix potentially typo that make unusual memory usage when uploaded a large file

The issue #1193 created months back

Noticed that line 67 of /graphql/handler/transport/http_form.go has potentially typo of using MaxUploadSize instead of MaxMemory

func (r *Request) ParseMultipartForm(maxMemory int64) error required max memory

This will cause problem when max upload size set to a large number

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 66.217% when pulling 21b223b on arkhvoid:master into 8494028 on 99designs:master.

@lwc
Copy link
Member

lwc commented Jul 13, 2020

Thanks!

@lwc lwc merged commit d7eabaf into 99designs:master Jul 13, 2020
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Fix typo cause memory problem on upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants