[issue #1258] explicitly add gqlparser alias to vektah/gqlparser/v2 import #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
[issue 99designs#1258] explicitly add gqlparser alias to vektah/gqlparser/v2 import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR and link to any relevant issues.
As described in #1258, generated.go doesn't compile with v0.11.3 (it used to work with v0.10.2). Compilation fails with:
Special aspects of our environment:
After debugging, realized that alias for github.com/vektah/gqlparser/v2 is computed as v2 while the generated!.gotpl uses
gqlparseralias. Since v2 alias is not used, it does get imported the generated.go file. Couldn't really find why alias is computed wrongly in our setup. However, updating generated!.gotpl template to explicitly use gqlparser alias got us a working generated.go. Hence this PR.I have: