Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert windows input path separators to slash #127

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

jon-walton
Copy link
Contributor

I found recently that generating from windows was causing circular imports within generated.go. looks like we had another case of windows file path issues.

this feels a bit hacky to me but thought i would start the discussion.

windows is able to use \ or / as a path separator. I'm not aware of any other (modern and supported ;) ) OS using \

one use case we might come across is the source files being on a UNC share which might be due to people using virtualbox etc and sharing the host's filesystem; not sure how likely that is, but anyway

@vektah
Copy link
Collaborator

vektah commented Jun 6, 2018

Cheers 👍

@vektah vektah merged commit 40d9a11 into 99designs:master Jun 6, 2018
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
convert windows input path separators to slash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants