Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rajas/fix gqlgen 1299 #1341

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Rajas/fix gqlgen 1299 #1341

merged 2 commits into from
Sep 28, 2020

Conversation

vmrajas
Copy link
Contributor

@vmrajas vmrajas commented Sep 28, 2020

Fixes #1299

I have:

  • Added tests covering the bug / feature (see testing)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.277% when pulling 789d02f on dgraph-io:rajas/fix-gqlgen-1299 into f4669ba on 99designs:master.

@vmrajas
Copy link
Contributor Author

vmrajas commented Sep 28, 2020

Hi @lwc,

Please help us in getting this PR reviewed. Is there any estimate about when the next version will be released.

Thanks

@lwc
Copy link
Member

lwc commented Sep 28, 2020

Thanks @vmrajas! LGTM. dgraph is finding a few issues with collectfields! Thanks :)

@lwc lwc merged commit 819e751 into 99designs:master Sep 28, 2020
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same field with alias in a fragment is getting ignored in collectFields
3 participants