fix template error on generated defaults #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2018 14:31
|
Thanks, you're cleaning up :) This could use a test, maybe just a second arg in https://github.com/vektah/gqlgen/blob/master/example/scalars/schema.graphql#L3? |
vektah
reviewed
Jun 25, 2018
example/scalars/generated.go
Outdated
| @@ -203,7 +203,7 @@ func (ec *executionContext) _Query_search(ctx context.Context, field graphql.Col | |||
| return graphql.Null | |||
| } | |||
| } else { | |||
| var tmp interface{} = map[string]interface{}{"location": "37,144", "isBanned": false} | |||
| var tmp interface{} = map[string]interface{}{"isBanned": false, "location": "37,144"} | |||
There was a problem hiding this comment.
Oh-oh! I think the map is making this non deterministic. Probably needs a sort first?
There was a problem hiding this comment.
yeah looks like it would need a sort.
|
Nice work |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
* fix template error on generated defaults * go fmt * add test for default fix * . * add key sort for default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #143 (comment)
The generated code doesn't separate default values with a comma. This adds a comma.
before:
after:
fixes #144